D10188: Sanitise notification HTML

Fabian Vogt noreply at phabricator.kde.org
Tue Jan 30 12:07:52 UTC 2018


fvogt added inline comments.

INLINE COMMENTS

> notificationsanitizer.cpp:34
> +    t.replace(QLatin1String("\n"), QStringLiteral("<br/>"));
> +    // Now remove all inner whitespace (\ns are already <br/>s
> +    t = t.simplified();

Missing `)`

> notificationsanitizer.cpp:57
> +            const QString name = r.name().toString();
> +            if (allowedTags.contains(name)) {
> +                out.writeStartElement(name);

Invert this and `continue` instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180130/d32a0941/attachment.html>


More information about the Plasma-devel mailing list