D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

[David Edmundson]

davidedmundson added a comment.


  Looks good. +1
  
  1 minor nitpick, but it's not super important.

INLINE COMMENTS

> TrafficMonitor.qml:55
>              left: parent.left
> -            leftMargin: units.iconSizes.medium
> +            leftMargin: units.iconSizes.large
>              right: parent.right

Semantically it's weird to use the size of an icon for a margin, unless you're trying to line up with an icon. There's a medium sized icon in the toolbar, which I assume is the intent here.

Can you rewrite this as "units.iconSizes.medium + largeSpacing"

Should equate to the same value, but self-documents what it's actually doing and handles a user changing icon sizes in the config file.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D10183

To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180129/f4af600e/attachment-0001.html>