D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D9070#197332, @rjvbb wrote:
  
  > What happens when you remove the `,Regular`
  
  
  That fixes the problem indeed.
  
  >>   Workaround: enabling the line that calls QApplication::setDesktopSettingsAware(false).
  >>   Proof that this code is guilty: commenting out the fromString line makes it work, too.
  > 
  > Which line is that, where?
  
  In the code shown by this patch ;) Line 80.
  But the test you suggested that I do above is further proof anyhow.
  
  >>   What really confuses me is: why isn't it all set up so that this platform-plugin code provides *default* fonts, and so that what apps do overrides that?
  > 
  > That is what used to be the case, and that's why I think the commit that added the setStyleName call to kfontsettingsdata.cpp ought to be reverted. (I haven't gone back to re-read the commit message, but IIRC it was mostly made to align with the way fonts are saved, without questioning whether they should always be saved like that.)
  
  But even without setStyleName call (i.e. with your patch) I get the bug, due to call to QFont::fromString.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180128/916f4134/attachment.html>