D6673: [Notifications] Manually remove remote images

[David Edmundson]

davidedmundson added a comment.


  > This would fail with "invalid but webbrowser-parseable" html, but i guess we don't really care about it either, no?
  
  That wouldn't solve anything as <img src="whatever" > without </img> would fail the XML remover but still end up getting loaded.
  You could need to signal that it wasn't strippable, and the QtQuick item could load in plain text, but then the patch is getting more complex.
  
  -----
  
  My comment looks surprisngly sensible, I'll follow that up tomorrow eve and see if it works. I'll run the test fvgot has in the earlier comment.
  
  -----
  
  > Any reason we're not doing the filtering at the dataengine level?
  
  It's accessing the text document of the TextEdit; which avoids a double text document parse.
  Though for the size of a notification at the frequency we get them, that's not a huge problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: aacid, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180128/1ebb5785/attachment-0001.html>