D10118: Disable keyboard geometry preview code

[David Edmundson]

davidedmundson added a comment.


  > it is not clear if this code is functional at this moment or not
  
  I'm -1 for disabling if the change is based on a false premise that it doesn't work.
  
  Is it something you've already lost several hours into trying to fix? If so this proposal has a lot more merit.
  
  If it is to be disabled, commenting something out when it's already in an if() block is not a good approach.
  Also any hacks always always need a code comment.
  
  -----
  
  FWIW:  ktouch has it's own layout parser / preview code.   It does update between UK and french and move the preview with the letters about, but switching to arabic returns an error, whereas the kcm preview works fine. Probably would need layer support too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10118

To: bshah, #plasma
Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180127/3dd747bb/attachment.html>