D10080: ensure the rounded rectangle of scrollbard stays round

Hugo Pereira Da Costa noreply at phabricator.kde.org
Wed Jan 24 20:42:32 UTC 2018


hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1262
> +        const qreal radius( qMin( (qreal)qMin(rect.width(), rect.height() ) / 2.0, 0.5*Metrics::ScrollBar_SliderWidth ) );
>  
>          // content

std::min( { a, b, c } )
would look nicer than qMin( qMin) 
Other than that ship it !

also, rather than (qreal)( rect.width() ) you can use directly baseRect.width(), which is a qRectF.

0.5*qMin( ... ) would also do the job. (as in 0.5*Metrics:: ... )
But in any case, std::min( ... )

REPOSITORY
  R31 Breeze

BRANCH
  phab/roudedsmallscroll

REVISION DETAIL
  https://phabricator.kde.org/D10080

To: mart, #plasma, #vdg, hpereiradacosta, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180124/88c8e449/attachment.html>


More information about the Plasma-devel mailing list