D9976: Display version alongside source, and use a combobox to switch between them

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jan 24 15:29:53 UTC 2018


apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  I think it's premature the adoption of the combo box, adding the version could make sense.

INLINE COMMENTS

> PackageKitResource.cpp:126
> +    // PackageKit folks expect us to format this string, so this is okay
> +    QString pkOrigin = PackageKit::Daemon::packageData(pkgid);
> +    return pkOrigin.remove(QStringLiteral("installed:"));

Seems like we are hitting a bug in PackageKit-Qt here, this is not right.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9976

To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska
Cc: plasma-devel, romangg, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180124/12136af5/attachment.html>


More information about the Plasma-devel mailing list