D10067: [Look and feel KCM] Destroy and recreate GHNS button when palette changes

Wed Jan 24 08:56:48 UTC 2018

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 389351
  FIXED-IN: 5.12.0

TEST PLAN
  See comment in the code.

  - GHNS dialog still shows
  - Changed from Breeze to Breeze dark, GHNS button updated immediately. Interestingly the check box updates just fine.

  I tried various other workarounds, such as an event filter installed by Breeze style to repaint or clear caches, I inspected the qquickstyleitem code to find a clue as to how trigger an update of its styleOption from outside but I didn't find one and franky I also didn't care enough.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10067

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180124/edbebad8/attachment-0001.html>