D10040: Add serial number and EISA ID to OutputDevice interface

[Daniel Vrátil]

dvratil marked 2 inline comments as done.
dvratil added inline comments.

INLINE COMMENTS

> davidedmundson wrote in outputdevice_interface.cpp:450
> You're not actually sending the serial number or eisa anywhere..
> 
> The others do it in sendGeometry (including the manufacturer)
> 
> When you do add it, you need to check the client is bound with version 2, otherwise you'll crash the client.
> 
> Something like
>  if(wl_proxy_get_version(resourceOfBoundClient) >= ORG_KDE_KWIN_SETSERIAL_SINCE_VERSION) {
> 
>   org_kde_output_...

I am sending the stuff in `sendGeometry()` (see right above)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10040

To: dvratil, graesslin, sebas
Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180123/7a61ef6e/attachment.html>