D10039: [WebBrowser Plasmoid] Port to QtWebEngine
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Jan 23 11:36:42 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, VDG, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
QtWebkit is old, unmaintained, possibly insecure, and also has quite a few bugs nowadays.
This also adds a couple of smaller features while at it:
- Reload button turns into a Stop button while loading
- Cursor changes shape over links
- Address bar selects all text when clicked to ease typing a completely new address
- Browser forward/back button on the mouse work
TEST PLAN
QtWebEngine doesn't auto-zoom to fit as QtWebKit did, so I tried to replicate that using zoomFactor.
Given the security implications and given that dict plasmoid uses QtWebEngine also, this could go into 5.12.
- Navigated a couple of pages
- It remembered the last visited page when plasma is restarted
- Scrolling with mouse wheel now works
- Context menus are using QQC plasma style
F5670542: Screenshot_20180123_123100.png <https://phabricator.kde.org/F5670542>
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10039
AFFECTED FILES
applets/webbrowser/contents/ui/main.qml
To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180123/902451a3/attachment.html>
More information about the Plasma-devel
mailing list