D9325: Use QUrl in the ScreenMapper API

Andras Mantia noreply at phabricator.kde.org
Tue Jan 23 11:28:15 UTC 2018


amantia added inline comments.

INLINE COMMENTS

> mwolff wrote in foldermodel.cpp:1509
> not your change: why is m_url not an url :-/
> 
> also: introduce the helper function you have in the tests here, too - maybe even move it into a static function in the ScreenMapper and then use it everywhere inplace of the QUrl::fromUserInput three-arg function call

m_url is exposed to QML, that doesn't support QUrl.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9325

To: amantia, #plasma, mwolff, dakon, broulik
Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180123/1dff077a/attachment.html>


More information about the Plasma-devel mailing list