D10031: Fix potential crash

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jan 23 00:48:03 UTC 2018


apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added projects: Plasma, Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Turns out in some weird (wrong) cases, ListView sets a negative maximum()
  value. This makes the application crash in qcommonstyle.cpp.
  This prevents the crash by making sure opt->maximum is never smaller than
  opt->minimum.

TEST PLAN
  Manual test, now Discover doesn't crash

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10031

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180123/b8ad3cf4/attachment-0001.html>


More information about the Plasma-devel mailing list