D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
David Edmundson
noreply at phabricator.kde.org
Mon Jan 22 12:44:23 UTC 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This reduces the code we have and implicitly fixes it under wayland.
Tracking of which windows are minimised by us is now done in JS, and
through use of model indexes instead of X window IDs, which wouldn't
really have worked under wayland.
Potentially we may have some minor behavioural differences on X with
regards to which windows are managed, as the old code did not skip those
with skip_taskmanager.
Requires a tiny patch in libtaskmanager to export persistentmodelindexes to
QML.
TEST PLAN
Under wayland:
Had 3 windows, one minimised already
Clicked button. All minimised.
Clicked again, two restored
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10019
AFFECTED FILES
applets/minimizeall/package/contents/ui/main.qml
applets/minimizeall/plugin/minimizeall.cpp
applets/minimizeall/plugin/minimizeall.h
applets/minimizeall/plugin/minimizeallplugin.cpp
applets/minimizeall/plugin/minimizeallplugin.h
applets/minimizeall/plugin/qmldir
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180122/41ec89f6/attachment.html>
More information about the Plasma-devel
mailing list