D10002: Improve header and screenshots
Nathaniel Graham
noreply at phabricator.kde.org
Sun Jan 21 03:50:58 UTC 2018
ngraham created this revision.
ngraham added reviewers: apol, abetts, andreaska, colomar, Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
- Increase size of app icon, name, and caption
- Remove blue line separating header and screenshots/description, since it was controversial and kind of pointless and inconsistent when the metadata section didn't have a text header
- Display screenshot thumbnails with the aspect ratio of the full-sized image, so they look better and nothing is cut off in the thumbnail
- Give screenshot thumbnails a drop shadow
Errata:
- The screenshots lost their hover effect as a side effect of the way the QML DropShadow effect had to be implemented. I tried many ways of adding it, and this was the way that caused the last amount of damage. Definitely open to suggestions.
TEST PLAN
Tested in KDE Neon:
Pitivi, before:
Pitivi, after:
Audacity, before:
Audacity, after
Clementine, before:
Clementine, after:
REPOSITORY
R134 Discover Software Store
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.kde.org/D10002
AFFECTED FILES
discover/qml/ApplicationPage.qml
discover/qml/ApplicationScreenshots.qml
To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180121/028263c8/attachment.html>
More information about the Plasma-devel
mailing list