D9792: even slimmer scrollbars

Rik Mills noreply at phabricator.kde.org
Sat Jan 20 13:25:56 UTC 2018


rikmills added a comment.


  In https://phabricator.kde.org/D9792#193697, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D9792#193473, @rikmills wrote:
  >
  > > In Neon and Kubuntu CI with Qt 5.9.3
  > >
  > > https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console
  > >
  > > 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function ‘virtual bool Breeze::Style::drawScrollBarSliderControl(const QStyleOption*, QPainter*, const QWidget*) const’:
  > >  17:55:15 /workspace/build/kstyle/breezestyle.cpp:5013:136: error: ‘const class QStyleOption’ has no member named ‘styleObject’
  > >  17:55:15          const bool widgetMouseOver( widget ? _animations->scrollBarEngine().isHovered( widget, QStyle::SC_ScrollBarGroove )  : option->styleObject->property("hover").toBool());
  > >  17:55:15                                                                                                                                         ^
  > >  17:55:15 kstyle/CMakeFiles/breeze.dir/build.make:910: recipe for target 'kstyle/CMakeFiles/breeze.dir/breezestyle.cpp.o' failed
  >
  >
  > Thanks for reporting.
  >  Looking at the log in more detail, this is in fact the qt4/kde4 built of breeze that fails.
  >  And indeed styleObject is not defined for qt4.
  
  
  Ah, I forgot that our builds were still making the Qt4 style. Also explains why the main KDE CI build did not fail!
  
  Thanks

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: rikmills, davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180120/9d8c9f12/attachment.html>


More information about the Plasma-devel mailing list