D9414: Implement OSD to select action when unknown monitors is connected

[Daniel Vrátil]

dvratil marked 15 inline comments as done.
dvratil added inline comments.

INLINE COMMENTS

> broulik wrote in osdmanager.cpp:60
> Shouldn't it rather do that in the plugin's `registerTypes`?

We don't have a QML plugin :( This is the only C++ class that is exposed to the OSD QML.

> broulik wrote in OsdSelector.qml:79
> Why do you need an `IconItem` inside? The `Button` can have an icon of its own

It's a workaround for Button's iconSource displaying the icon as 24x24  regardless of the size of the button, so we end up with massive button with a tiny icon.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D9414

To: dvratil, sebas, davidedmundson, #vdg
Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180119/8b7b1dc8/attachment.html>