D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> anemeth wrote in blur.cpp:145
> I checked if I have these extensions. Just to make sure it works I included another extension I know my card supports.
> 
>   qCDebug(KWINEFFECTS) << "NV_texture_barrier:" << hasGLExtension("NV_texture_barrier");
>   qCDebug(KWINEFFECTS) << "ARB_texture_barrier:" << hasGLExtension("ARB_texture_barrier");
>   qCDebug(KWINEFFECTS) << "GL_NV_texgen_reflection:" << hasGLExtension("GL_NV_texgen_reflection");
> 
> And the output:
> 
>   kwineffects: NV_texture_barrier: false
>   kwineffects: ARB_texture_barrier: false
>   kwineffects: GL_NV_texgen_reflection: true
> 
> If this works so unreliably I don't think we should use this.

Ok I realize now that the extension name begins with GL_ and this is the reason it didn't find them.
BUT then I listed all the available extensions and since they are in alphabetical order I can easily check if texture_barrier is available.
F5662968: Képkivágás2.PNG <https://phabricator.kde.org/F5662968>
The red arrow is where they should be but they aren't present.
So my point still stands.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180119/d2940879/attachment.html>