D9892: cmake: Use the official CMake variable for building as a static plugin.
    Emmanuel Lepage Vallee 
    noreply at phabricator.kde.org
       
    Thu Jan 18 08:03:38 UTC 2018
    
    
  
lepagevalleeemmanuel added a comment.
  I tried the patch on my CI and it compiled and linked. I also reviewed the changes between my patchset and this diff and approve the change, I also agree with Apol about the `target_link_libraries` issue. It should be mutualized between the `if` and `else`. So "almost ship it!"
REPOSITORY
  R169 Kirigami
REVISION DETAIL
  https://phabricator.kde.org/D9892
To: mart, #kirigami, lepagevalleeemmanuel
Cc: apol, plasma-devel, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180118/1c88135b/attachment.html>
    
    
More information about the Plasma-devel
mailing list