D9786: [Kickoff] Fix RTL issues

[Kai Uwe Broulik]

broulik added a comment.


  Looking good!

INLINE COMMENTS

> ApplicationsView.qml:112
> +            // HACK: Align the content to right for RTL locales
> +            leftMargin: LayoutMirroring.enabled ? Math.max(0, width - contentWidth) : undefined
> +

`leftMargin` does not have a `RESET` property, ie. you cannot assign `undefined` to it. Just set it to zero instead.

> ApplicationsView.qml:138
>                  onWidthChanged: {
> -                    breadcrumbFlickable.contentX = Math.max(0, breadcrumbsElement.width - breadcrumbFlickable.width)
> +                    if (!LayoutMirroring.enabled)
> +                        breadcrumbFlickable.contentX = Math.max(0, breadcrumbsElement.width - breadcrumbFlickable.width)

You can turn it around, also use braces even for single line statements

  if (LayoutMirroring.enabled) {
      ...
  } else {
      ...
  }

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9786

To: safaalfulaij, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180115/77a0f602/attachment.html>