D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> slide.cpp:62
>  
> -    const auto d = animationTime(
> -        SlideConfig::duration() != 0 ? SlideConfig::duration() : 250);
> -    mTimeLine.setDuration(d);
> +    m_timeline.setDuration(animationTime(SlideConfig::duration()));
> +    m_hGap = SlideConfig::horizontalGap();

So far the interpretation of the config values was: 0 means default settings, anything else means taken from the config. As we have old configs this change would basically disable the animation for everybody with default settings. Given that I suggest to keep the approach as in the old variant.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180113/d9d79bea/attachment-0001.html>