D9835: Bump min cmake version to 3.0
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Fri Jan 12 06:16:36 UTC 2018
kossebau added a subscriber: hein.
kossebau added inline comments.
INLINE COMMENTS
> CMakeLists.txt:99
>
> -ecm_configure_package_config_file(LibTaskManagerConfig.cmake.in
> +configure_package_config_file(LibTaskManagerConfig.cmake.in
> "${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cmake"
@hein BTW, that LibTaskManagerConfig.cmake misses some `find_dependency()`s (+`include(CMakeFindDependencyMacro)` after this patch) for all the libs in the public interface.
Sadly cmake does not generate that itself, so one has to manually note them.
Similar possibly for the other installed cmake config files.
Cmp. e.g.
https://phabricator.kde.org/source/plasma-framework/browse/master/KF5PlasmaConfig.cmake.in;fab4cdd95b7ceb4e608f8e4368682fe0a589ccff$17
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9835
To: kossebau, #plasma, jriddell
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180112/52f3d0a4/attachment.html>
More information about the Plasma-devel
mailing list