D9754: [Notifications] Use custom DragHelper instead of Qt's Drag attached property

[David Edmundson]

davidedmundson added a comment.


  You know my rule by now. If we're working round a Qt bug, we should have a Qt bug report.

INLINE COMMENTS

> draghelper.cpp:50
> +    // This allows the caller to return, making sure we don't crash if
> +    // the caller is destroyed mid-drag (as can happen due to a sycoca
> +    // change).

sycoca change?

> draghelper.cpp:63
> +
> +    QDrag *drag = new QDrag(item);
> +

This leaks drags over the lifespan of the item, not deleting after drop.

> draghelper.cpp:80
> +
> +    drag->exec();
> +

:/ really?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9754

To: broulik, #plasma, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180111/46b17f99/attachment.html>