D9816: Ensure DesktopIcon paints with the correct aspect ratio

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Thu Jan 11 12:23:47 UTC 2018


leinir created this revision.
leinir added reviewers: Kirigami, Discover Software Store.
leinir added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The simple QML based Icon already provides this correctly, but DesktopIcon would not output in the correct location and aspect ratio, and rather draw the image scaled into the entirety of the node rectangle.
  
  This fixes the issue described in https://bugs.kde.org/show_bug.cgi?id=388737

TEST PLAN
  Without this patch, Discover shows items as seen in the attachment on the bug
  
  With this patch, the output is as expected (with the correct aspect ratio and centered in the item)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9816

AFFECTED FILES
  src/desktopicon.cpp

To: leinir, #kirigami, #discover_software_store
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180111/b74c70f2/attachment.html>


More information about the Plasma-devel mailing list