D9792: even slimmer scrollbars
Marco Martin
noreply at phabricator.kde.org
Thu Jan 11 10:01:46 UTC 2018
mart added inline comments.
INLINE COMMENTS
> hpereiradacosta wrote in breezestyle.cpp:5041
> This whole code feels hackish.
> In principle we know (elsewhere in the code), if any part of the scrollbar is hovered, since it is used to make the groove appear.
> I checked that this is done in a separate method though, namely Breeze::Style::drawScrollBarComplexControl, which calls the base class method in the end, which in turn ends up calling this method.
> I wonder if we should not simply move the code from drawScrollbarSliderControl to the ComplexControl method, thus making the hacking above unnecessary. (makes sense ?)
you mean making drawScrollBarSliderControl a complete noop?
REPOSITORY
R31 Breeze
BRANCH
phab/slimScrollbars
REVISION DETAIL
https://phabricator.kde.org/D9792
To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180111/f5a79043/attachment.html>
More information about the Plasma-devel
mailing list