D9799: [Panel View] Check if it's the same applet we're configuring before just hiding current view

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This fixes opening panel controller while an applet config dialog was open.
  It would find that we want to show config for a panel but find a config is already open, so it would just close it, even though it was not the panel controller (which should be toggleable) but another applet config.
  While at it restructure if statements a bit.

TEST PLAN
  - Opening panel controller still works
  - Closing panel controller when open (toggle) still works
  - Opening applet config with panel controller open closes panel controller and opens applet dialog
  - Opening panel controller with applet config open //now// closes applet dialog //and then// opens panel controller ← this was buggy
  - Opening another applet config still closes current applet config and opens new one

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9799

AFFECTED FILES
  shell/panelview.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180110/a6b1d2b7/attachment.html>