D9689: Add a per-process CPU usage graph shown in the process list

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> ksysguardprocesslist.cpp:124
> +            // Draw the history graph
> +            if(hasHistory)
> +            {

Coding style

> processtest.cpp:221
> +void testProcess::testCPUGraphHistory() {
> +    KSysGuardProcessList *processList = new KSysGuardProcessList;
> +    processList->show();

This leaks (note how the other tests delete it afterwards), or wrap it in a `QScopedPointer`

> processtest.cpp:226
> +    // Access the PercentageHistoryRole to enable collection
> +    for(int i = 0; i < model->rowCount({}); i++) {
> +        auto index = model->index(i, ProcessModel::HeadingCPUUsage, {});

`rowCount()` already has a default argument for `index`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D9689

To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180110/286c7fb8/attachment-0001.html>