D9764: [WIP] a basic TabletModeManager

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> tabletmodemanager.cpp:75
> +{
> +    m_spy = new TabletModeInputEventSpy(this);
> +    input()->installInputEventSpy(m_spy);

please put into initializer.

Also the spy leaks.

> tabletmodemanager.cpp:86-87
> +TabletModeManager::~TabletModeManager()
> +{
> +}
> +

= default

> tabletmodemanager.cpp:106
> +
> +#include "tabletmodemanager.moc"

is that needed?

> workspace.cpp:183
>  
> +    TabletModeManager::create(this);
> +

I would create it in main_wayland.cpp in ApplicationWayland::performStartup just before creating the virtualkeyboard.

Reason: this is currently Wayland only code and we might not want to expose the dbus service on X11. Reason for just before creating virt keyboard: I want to use that to automatically enable the virtual keyboard if we are in tablet mode.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9764

To: mart, #plasma, #kwin
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180109/d74b20c6/attachment.html>