D9763: [Slideshow] Don't repeatedly restart on startup

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jan 9 13:44:52 UTC 2018


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Wait for `m_ready` until doing anything. This keeps the slideshow from first showing the default wallpaper, then a random slideshow image, and then fade to the next slideshow image.

TEST PLAN
  - Switching slideshow wallpapers is still animated
  - clicking "Next wallpaper" in context menu still works
  - Copying a file to the picture folder will add it to the slideshow just fine
  
  Removed the `setSingleImage()` call in the constructor which would never do anything as it's guarded by `m_ready`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9763

AFFECTED FILES
  wallpapers/image/image.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180109/5bf320d5/attachment.html>


More information about the Plasma-devel mailing list