D9735: [Notifications] Don't restart hide timer on reposition while dragging

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Because I do timer.stop() (lines 101ff) when I start dragging, I dont want it to ever go away while dragging.
  
  So semantically it's not about whether we restart a running timer, but more about making sure we don't start a stoppped timer.
  
  As an improvement that happens to also avoid a bug that's absolutely fine.  +1
  
  But:
  
  > If I drop, then it tries to access the drag area or drag to get the data or emit signals and then it blows up because the popup is no longer there.
  
  If you're trying to say it's a Qt bug, then it need* a Qt bug report. Even if it's just the trace from bugzilla.
  
  Also the popup is there, but it resets the thunbmail strip loader which owns the mouse area which owns the drag. Though normally I've only seen this sort of crash when we delete something cross engines

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9735

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180109/c03ba9a4/attachment-0001.html>