D9751: [weather] Add configuration option which weather services providers to use

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Jan 9 07:07:50 UTC 2018


kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  When searching a weather station/location to select for the weather applet,
  so far the user had no chance to control which weather services providers
  are queried. Instead simply all are given the search string. Which can both
  result in unwanted hits due to regions covered, as well as some minimal
  privacy breach.
  
  This patch adds a dropdown menu to the search form where the user can
  control which services providers are used. The settings selected is stored
  in the config for the given applet instance.
  
  The setting defaults to an empty list, so the user has to opt-in to the use
  of any provider.
  
  Ideally the dropdown menu listing the providers with checkboxes would stay
  open after toggling a selection, but QtComponents Menu seems to not allow
  any modification of that behaviour. This is a small annoyance, but only once
  in a while.

REPOSITORY
  R114 Plasma Addons

BRANCH
  allowconfigureweatherproviderqueried

REVISION DETAIL
  https://phabricator.kde.org/D9751

AFFECTED FILES
  applets/weather/CMakeLists.txt
  applets/weather/package/contents/ui/configWeatherStation.qml
  applets/weather/plugin/locationlistmodel.cpp
  applets/weather/plugin/locationlistmodel.h
  applets/weather/plugin/plugin.cpp
  applets/weather/plugin/servicelistmodel.cpp
  applets/weather/plugin/servicelistmodel.h
  applets/weather/weatherapplet.cpp
  applets/weather/weatherapplet.h

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180109/12265714/attachment-0001.html>


More information about the Plasma-devel mailing list