D9735: [Notifications] Don't restart hide timer on reposition while dragging

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jan 8 15:18:56 UTC 2018


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We checked for dragging in `onContainsMouseChanged` but not here.
  
  BUG: 388684
  FIXED-IN: 5.12.0

TEST PLAN
  Emitted a notification, then saved a screenshot, started dragging, the top notification disappeared and mine stayed open. Before it would also close after a while and then crash.
  Still auto-hides if shown with no user interaction.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9735

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180108/e1c3e5eb/attachment.html>


More information about the Plasma-devel mailing list