D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jan 8 14:20:12 UTC 2018


broulik added a comment.


  Thanks for your patch! I'll let David have a look at it who maintains xembedsniproxy.

INLINE COMMENTS

> sniproxy.cpp:292
> +    QImage naiveConversion;
> +	if (nullptr != image) {
> +		naiveConversion = QImage(image->data, image->width, image->height, QImage::Format_ARGB32);

Just do

  if (image) {

The indentation seems a little off, we use four spaces for indentation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9732

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180108/0ccb509d/attachment.html>


More information about the Plasma-devel mailing list