D9726: Change device "master volume" to be the max of all channels instead of the avg

Chris Holland noreply at phabricator.kde.org
Mon Jan 8 02:47:54 UTC 2018


Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  When we use the avg, it's very easy to "boost" the "right speaker" over 100%.
  
  Before this patch, if you set the left channel to 50% and leave the right channel at 100% (via pavucontrol), the "master channel" will be the average of 75%. If you then raise the "master channel" by 10%, you raise the right channel to 110%.
  
  Bug: 388553
  
  -----
  
  https://bugs.kde.org/show_bug.cgi?id=388553
  
  Before: https://streamable.com/2kp7m
  After: https://streamable.com/5n56s

TEST PLAN
  Installed pavucontrol. Unlocked the channels. See "After" video.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9726

AFFECTED FILES
  src/context.h
  src/volumeobject.cpp

To: Zren, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180108/8a5d7914/attachment.html>


More information about the Plasma-devel mailing list