D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Henrik Fehlauer]

rkflx added a comment.


  Thanks for the review and your help ;)

INLINE COMMENTS

> hpereiradacosta wrote in breezedecoration.cpp:643
> Matter of taste. 
> Some people (including me), like to have the default (fallback) choice first. 
> Some others like to have it last.
> Some, inline.
> There is no c++ rule about this as far as I know.

Fair enough. However, the other `defaults` in the same file are ordered already…

> hpereiradacosta wrote in breezeconfigwidget.cpp:91
> No
> Only the first should be ShadowVeryLarge
> The second (l92) should remain "ShadowLarge", or rather whatever the default shadow size we want. 
> The logic behind this is that if the shadowSize is "invalid" (meaning: larger than the largest possible value), you fallback to the default value. 
> This way we gracefully reset all previously set sizes (from spinbox) to the default size.

Oops, I was sloppy on the second one. (I guess the root problem the int/enum conversion kcfg requires? But that's OT)

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180106/d63703f4/attachment.html>