D9638: [effects] add 'Slide Desktops' effect

Vlad Zagorodniy noreply at phabricator.kde.org
Thu Jan 4 12:04:27 UTC 2018


zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Memory allocations in `SlideDesktopsEffect::paintScreen()` creep me out. We should not allocate memory during paint calls! If you have any ideas how to solve this, please let me know. Currently, I'm thinking about reusing a vector(for `visibleDesktops`) and a boolean matrix(for `m_paintCtx.fullscreenWindows`; I guess name should be changed).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180104/8ec06638/attachment.html>


More information about the Plasma-devel mailing list