D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

David Edmundson noreply at phabricator.kde.org
Wed Jan 3 09:58:56 UTC 2018


davidedmundson added inline comments.

INLINE COMMENTS

> dbusmenuimporter.cpp:436
>                  auto menu = action->menu();
>                  connect(menu, &QMenu::aboutToShow, this, [menu, this]() {
> +                    updateMenu(menu);

This needs to be a unique connection see https://phabricator.kde.org/D5706

(which might mean moving updateMenu into slotMenuAboutToShow)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9631

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180103/44ed705d/attachment.html>


More information about the Plasma-devel mailing list