D9608: [KScreen Effect] Fade opacity only for transparent windows

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  When you have two windows ontop of each other and you turn them transparent, evidently you'll be able to see through them.
  Not only does it look unpolished if the desktop window flashes through your windows, it can pose a privacy risk as you'd be able to briefly look through the lock screen.
  
  BUG: 388384

TEST PLAN
  I could no longer see my desktop flashing through when suspending and also was unable to look through the lock screen during the animation. It looks a lot nicer now as we mostly fade to black now instead of "fading through to the black root window".
  Transparent windows are still fading their opacity as brightness would only affect opaque parts and then you end up with floating black icons in case of e.g. your panel.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9608

AFFECTED FILES
  effects/kscreen/kscreen.cpp

To: broulik, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180102/5678f1fd/attachment.html>