D10901: Add "move to device" functionality to hamburger menu

David Rosca noreply at phabricator.kde.org
Tue Feb 27 21:11:03 UTC 2018


drosca added inline comments.

INLINE COMMENTS

> ListItemBase.qml:340
> +                var menuItem = newMenuItem();
> +                if(type == "sink-input") {
> +                    menuItem.text = i18nc("Heading for a list of possible output devices (speakers, headphones, ...) to choose", "Play audio using");

`if (`

> ListItemBase.qml:343
> +                }
> +                else {
> +                    menuItem.text = i18nc("Heading for a list of possible input devices (built-in microphone, headset, ...) to choose", "Record audio using");

`} else {` on the same line

> ListItemBase.qml:350
> +
> +
> +                for (var i = 0; i < sModel.count; ++i) {

extra newline

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180227/954c8ebd/attachment.html>


More information about the Plasma-devel mailing list