D10835: [kicker] Never execute recent documents

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:286
>          if (!resource.startsWith(QLatin1String("applications:"))) {
> -            new KRun(docData(resource, Kicker::UrlRole).toUrl(), 0);
> +            QUrl resourceUrl = docData(resource, Kicker::UrlRole).toUrl();
> +

const

> recentusagemodel.cpp:288
> +
> +            QList<QUrl> urlsList;
> +            urlsList.append(resourceUrl);

const QList<QUrl> urlsList{ resourceUrl };

> recentusagemodel.cpp:294
> +            KService::Ptr service = KMimeTypeTrader::self()->preferredService(mime.name());
> +            if (service != nullptr) {
> +                KRun::runApplication(*service, urlsList, nullptr);

if (service) {

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10835

To: aleksejshilin, #plasma
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180226/d4d7b3f7/attachment-0001.html>