D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

Martin Flöser noreply at phabricator.kde.org
Sun Feb 25 20:17:43 UTC 2018


graesslin added a comment.


  In D10816#213801 <https://phabricator.kde.org/D10816#213801>, @broulik wrote:
  
  > Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/
  
  
  Yes, this is only intended to be used till Plasma depends on Qt 5.11.

INLINE COMMENTS

> broulik wrote in kworkspace.h:161
> Can you `assert` this?

I'll rephrase it, it's not a "must", it's just a "must happen before if one wants to use it". Given that I don't think an assert is required.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180225/e5883860/attachment-0001.html>


More information about the Plasma-devel mailing list