D10549: Don't crash if the cursor theme fails to create

Roman Gilg noreply at phabricator.kde.org
Sat Feb 24 19:48:23 UTC 2018


romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> wayland_cursor_theme.cpp:69
>                                     size, m_shm->shm());
> -    emit themeChanged();
> +    if (theme) {
> +        if (!m_theme) {

Only do if theme really changes (`theme && m_theme != theme`).

> wayland_cursor_theme.cpp:79
> +    }
>  }
>  

On `!theme`: Add debug output that `theme`could not be loaded.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180224/d6659b95/attachment.html>


More information about the Plasma-devel mailing list