D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status
Matthijs Tijink
noreply at phabricator.kde.org
Sat Feb 24 17:32:37 UTC 2018
mtijink created this revision.
mtijink added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mtijink requested review of this revision.
REVISION SUMMARY
At #kde_connect <https://phabricator.kde.org/tag/kde_connect/> we had some visual glitches whenever the plasma browser integration reported `playing` or `paused`. The cause was that the player was already signalled as paused, but `canPlay` was not signalled as `true` yet.
This diff fixes the issue by just always reporting `true`. This is also what the specifications require (see https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Property:CanPlay)
TEST PLAN
The glitch never appeared for me, but the code compiles and works fine with this change.
REPOSITORY
R856 Plasma Browser Integration
BRANCH
fix-mpris-canplaypause
REVISION DETAIL
https://phabricator.kde.org/D10800
AFFECTED FILES
host/mprisplugin.cpp
To: mtijink, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180224/2794211d/attachment-0001.html>
More information about the Plasma-devel
mailing list