D10713: Render application icon at paintdevice DPR

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QIcon::pixmap doesn't know anything about the paint device currently
  being used so uses qApp->devicePixelRatio.
  This works in systemsettings, but not in kwin and we get a standard
  resolution pixmap returned.
  
  We can't manually multiply by painter->device->dpr because then system
  settings would get scaled twice.
  
  QIcon::paint solves that in a way that won't break should kwin's
  qApp->dpr change. Also it's IMHO cleaner as it does the alignment
  internally.
  
  BUG: 390639

TEST PLAN
  System settings look the same
  Icon in kwin deco is crisper than before

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10713

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180221/2d7fcfbd/attachment.html>