D10695: dont initialize app menu index in every hiding

Michail Vourlakos noreply at phabricator.kde.org
Tue Feb 20 19:14:15 UTC 2018


mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  - hiding a menu shouldnt initialize the currentIndex to -1
  
  at all cases. When a secondary menu is already shown then
  the currentIndex should be only the index of the new menu.
  This improves also the qml bindings because currentIndex
  doesnt change all the time with no reason.

TEST PLAN
  added debug messages in qml side to check the value of
  currentIndex

REPOSITORY
  R120 Plasma Workspace

BRANCH
  global

REVISION DETAIL
  https://phabricator.kde.org/D10695

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: mvourlakos, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180220/ef63d0e7/attachment.html>


More information about the Plasma-devel mailing list