D10692: parent full representation to the proper window at start

David Edmundson noreply at phabricator.kde.org
Tue Feb 20 19:13:52 UTC 2018


davidedmundson added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:29
>  
> +    //set width/height to avoid an useless Dialog resize
> +    width: Layout.minimumWidth

How does this avoid a useless Dialog resize?

> systemtray.cpp:346
>  
> +void SystemTray::createPopup(QQuickWindow *window)
> +{

why did this need special code, but kicker (not kickoff) which also does its own didn't?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180220/05c0f301/attachment.html>


More information about the Plasma-devel mailing list