D10652: [Run Command] Add history drop down button

[Nathaniel Graham]

ngraham added a comment.


  Indeed; I never discovered it! This is great.

INLINE COMMENTS

> RunCommand.qml:125
> +                    right: parent.right
> +                    rightMargin: 6 // from PlasmaStyle TextFieldStyle
> +                    verticalCenter: parent.verticalCenter

Do we have a programmatic value we can use here instead of a magic number?

> RunCommand.qml:129
> +                // match clear button
> +                width: Math.max(parent.height * 0.8, units.iconSizes.small)
> +                height: width

Ditto; maybe we should make `units.iconSizes.small` reflect the actual size that we want and just use that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180219/8dacaa3d/attachment.html>