D10620: Improve sidebar header visibility

Marco Martin noreply at phabricator.kde.org
Mon Feb 19 09:37:01 UTC 2018


mart added a comment.


  I'm ok with making the text darker in the headers.
  I'm not exactly sure why as viewbackgroundcolor should be correct(tough deprecated), but in the breeze light screenshots the headers have a background slightly ligher than the other elements, which makes it look a bit weird

INLINE COMMENTS

> CategoriesPage.qml:134
> +                // Ideally, we would use real header items
> +                background: Rectangle {
> +                    color: Kirigami.Theme.viewBackgroundColor

hoverEnabled: false should be enough (iirc there are also properties to make it not do mousepressed effects)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180219/556593b4/attachment.html>


More information about the Plasma-devel mailing list