D10610: Fix favicons in firefox bookmarks runner

[Luca Weiss]

z3ntu marked an inline comment as done.
z3ntu added a comment.


  Thanks :)
  
  > Presumably this means it'll break on < Firefox 58?
  
  It should work FF37+ where they switched to the new database schema.
  
  > It's weird that it crashes on a table missing. Is that a Qt bug we can file?
  
  It seems to be QTBUG-66443 <https://bugreports.qt.io/browse/QTBUG-66443> and yes, it's definitely a Qt bug as the same SQL statement just returns `false` in my test file as it should.

INLINE COMMENTS

> davidedmundson wrote in firefox.cpp:69
> where does this get deleted?

Sorry, fixed it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10610

To: z3ntu, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180217/bed794de/attachment.html>