D10610: Fix favicons in firefox bookmarks runner

[Luca Weiss]

z3ntu added a comment.


  Two more notes:
  
  The logic for the path of the cache file (bookmarkrunnerfirefoxfavdbfile.sqlite) is like in D10605 <https://phabricator.kde.org/D10605>.
  If this patch doesn't get merged into the next Plasma bugfix release, then `QList<QVariantMap> faviconFound = m_fetchsqlite->query(m_buildQuery, bindVariables);` could be replaced with `QList<QVariantMap> faviconFound;` to just not run the sql code and avoid the crashes caused by this bug.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10610

To: z3ntu
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180217/9de0f399/attachment-0001.html>