D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sat Feb 17 15:55:15 UTC 2018
kossebau created this revision.
kossebau added reviewers: FreeBSD, tcberner, bshah, mart, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail
Moving the K_PLUGIN_FACTORY_WITH_JSON into a separate file only added
to the sources of kcm_lookandfeel, instead of hiding with an ifndef for
the build of the lookandfeeltool target as tried before, should avoid
any potential confusion of automoc as reported from some builds
(on KDE neon?).
REPOSITORY
R119 Plasma Desktop
BRANCH
fixkcmlooknfeelmoctake2
REVISION DETAIL
https://phabricator.kde.org/D10607
AFFECTED FILES
kcms/lookandfeel/CMakeLists.txt
kcms/lookandfeel/kcm.cpp
kcms/lookandfeel/kcmmain.cpp
To: kossebau, #freebsd, tcberner, bshah, mart, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180217/6b7a15af/attachment.html>
More information about the Plasma-devel
mailing list